refactor(filter-predicate): move client filters to its own function. …

…Also allows for Client filters to completely hide posts

mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/StatusDisplayItem.java

@@ -331,6 +331,10 @@ else if(statusForContent.sensitive && AccountSessionManager.get(accountID).getLo
 			applyingFilter = predicate.getApplyingFilter();
 		}
 
+		// Hide statuses that have a filter action of hide
+		if(!new StatusFilterPredicate(accountID, filterContext, FilterAction.HIDE).test(status))
+			return new ArrayList<StatusDisplayItem>() ;
+
 		return statusForContent.filterRevealed ? items :
 				new ArrayList<>(List.of(new WarningFilteredStatusDisplayItem(parentID, fragment, statusForContent, items, applyingFilter)));
 	}

mastodon/src/main/java/org/joinmastodon/android/utils/StatusFilterPredicate.java

@@ -17,6 +17,7 @@
 import org.joinmastodon.android.model.Status;
 
 import java.time.Instant;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 import java.util.function.Predicate;
@@ -39,8 +40,7 @@ public StatusFilterPredicate(List<LegacyFilter> filters, FilterContext context,
 		this.filters = filters;
 		this.context = context;
 		this.action = action;
-		this.clientFilters = GlobalUserPreferences.showPostsWithoutAlt ? List.of()
-				: List.of(new AltTextFilter(WARN, HOME, PUBLIC, ACCOUNT, THREAD, NOTIFICATIONS));
+		this.clientFilters = getClientFilters();
 	}
 
 	public StatusFilterPredicate(List<LegacyFilter> filters, FilterContext context){
@@ -56,8 +56,15 @@ public StatusFilterPredicate(String accountID, FilterContext context, FilterActi
 		filters=AccountSessionManager.getInstance().getAccount(accountID).wordFilters.stream().filter(f->f.context.contains(context)).collect(Collectors.toList());
 		this.context = context;
 		this.action = action;
-		this.clientFilters = GlobalUserPreferences.showPostsWithoutAlt ? List.of()
-				: List.of(new AltTextFilter(WARN, HOME, PUBLIC, ACCOUNT, THREAD, NOTIFICATIONS));
+		this.clientFilters = getClientFilters();
+	}
+
+	private List<LegacyFilter> getClientFilters() {
+		List<LegacyFilter> filters = new ArrayList<>();
+		if(!GlobalUserPreferences.showPostsWithoutAlt) {
+			filters.add(new AltTextFilter(WARN, HOME, PUBLIC, ACCOUNT, THREAD, NOTIFICATIONS));
+		}
+		return filters;
 	}
 
 	/**