Expose de/serialize for Sender, Receiver #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGould
force-pushed
the
to-from-json
branch
from
16d149e to
437bdac
Compare
These structs need to be serialized and deserialized in order to be persisted in a downstream database. We use json to do this only because that decision was made in payjoin-cli. A binary encoding could be used as well, but that bikeshed is to be built at a later date.
spacebear21
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These structs need to be serialized and deserialized in order to be persisted in a downstream database.
We use json to do this only because that decision was made in payjoin-cli. A binary encoding could be used as well, but that bikeshed is to be built at a later date.