Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of arguments #46

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix order of arguments #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/classes/Blockchain.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe('Blockchain', () => {

blockChain = await new Blockchain().create(esploraConfig, BlockChainNames.Esplora);
expect(blockChain.id).toBe('esplora');
expect(mockBdkRnModule.initEsploraBlockchain).toHaveBeenCalledWith(url, proxy, concurrency, timeout, stopGap);
expect(mockBdkRnModule.initEsploraBlockchain).toHaveBeenCalledWith(url, proxy, concurrency, stopGap, timeout);
});

it('initialises with rpc config', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/classes/Blockchain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class Blockchain extends NativeLoader {
this.id = await this._bdk.initElectrumBlockchain(url, retry, stopGap, timeout);
} else if (BlockChainNames.Esplora === blockchainName) {
const { url, proxy, concurrency, timeout, stopGap } = config as BlockchainEsploraConfig;
this.id = await this._bdk.initEsploraBlockchain(url, proxy, concurrency, timeout, stopGap);
this.id = await this._bdk.initEsploraBlockchain(url, proxy, concurrency, stopGap, timeout);
} else if (BlockChainNames.Rpc === blockchainName) {
this.id = await this._bdk.initRpcBlockchain(config as BlockchainRpcConfig);
} else {
Expand Down