Gracefully handle invalid addressIndex type by falling back to new

LtbLightning · Nov 15, 2023 · 84ae5a1 · 84ae5a1
1 parent 4f47402
commit 84ae5a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/android/src/main/java/io/ltbl/bdkrn/BdkRnModule.kt b/android/src/main/java/io/ltbl/bdkrn/BdkRnModule.kt
@@ -395,7 +395,7 @@ class BdkRnModule(reactContext: ReactApplicationContext) :
                         resolvedIndex = (addressIndex as Dynamic).asDouble() ?: "new"
                     }
                     else -> {
-                        result.reject("Invalid address index type", "Address index must be a String or an Int")
+                        resolvedIndex = setAddressIndex("new")
                     }
                 }
                 val addressInfo = getWalletById(id).getAddress(setAddressIndex(resolvedIndex))
@@ -425,7 +425,7 @@ class BdkRnModule(reactContext: ReactApplicationContext) :
                         resolvedIndex = (addressIndex as Dynamic).asDouble() ?: "new"
                     }
                     else -> {
-                        result.reject("Invalid address index type", "Address index must be a String or an Int")
+                        resolvedIndex = setAddressIndex("new")
                     }
                 }
                 val addressInfo = getWalletById(id).getInternalAddress(setAddressIndex(resolvedIndex))

diff --git a/ios/BdkRnModule.swift b/ios/BdkRnModule.swift
@@ -501,8 +501,7 @@ class BdkRnModule: NSObject {
             } else if let indexInt = addressIndex as? Int {
                 resolvedIndex = setAddressIndex(addressIndex: indexInt)
             } else {
-                reject("Invalid address index type", "Address index must be a String or an Int", nil)
-                return
+                resolvedIndex = setAddressIndex(addressIndex: "new")
             }
 
             let addressInfo = try getWalletById(id: id).getAddress(
@@ -530,8 +529,7 @@ class BdkRnModule: NSObject {
             } else if let indexInt = addressIndex as? Int {
                 resolvedIndex = setAddressIndex(addressIndex: indexInt)
             } else {
-                reject("Invalid address index type", "Address index must be a String or an Int", nil)
-                return
+                resolvedIndex = setAddressIndex(addressIndex: "new")
             }
             let addressInfo = try getWalletById(id: id).getInternalAddress(
                 addressIndex: resolvedIndex