Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): Color mode switch error #223

Closed
wants to merge 1 commit into from

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Jan 4, 2025

Plz review and merge this PR before #221

Summary by Sourcery

Bug Fixes:

  • Fix an issue where the window effect color was not being applied correctly on iOS devices.

Copy link

sourcery-ai bot commented Jan 4, 2025

Reviewer's Guide by Sourcery

This PR fixes an issue with the color mode switch on iOS devices. The micaBackgroundColor is now used if the window effect is solid or if the platform is iOS.

State diagram for color mode behavior

stateDiagram-v2
    [*] --> CheckPlatformAndEffect
    CheckPlatformAndEffect --> UseMicaBackground: Platform is iOS OR
WindowEffect is Solid
    CheckPlatformAndEffect --> UseTransparent: Other cases
    UseMicaBackground --> [*]
    UseTransparent --> [*]
Loading

File-Level Changes

Change Details Files
Use micaBackgroundColor if the window effect is solid or the platform is iOS.
  • Added a platform check for iOS to use micaBackgroundColor if the window effect is solid or if the platform is iOS.
  • Updated the condition for using micaBackgroundColor to include iOS devices.
lib/main.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed PR description that explains:
  • What color mode switch error was occurring on iOS
  • How this fix resolves the issue
  • How to verify the fix works
  • Why this needs to be merged before PR fix(iOS): Support secure bookmarks #221
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Owner

@Losses Losses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@@ -390,7 +390,7 @@ class _RuneState extends State<Rune> {
final theme = FluentTheme.of(context);

Widget content = Container(
color: appTheme.windowEffect == WindowEffect.solid
color: (appTheme.windowEffect == WindowEffect.solid || Platform.isIOS)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows related window effect logic is already defined in another place, please organize them together to make the code maintainable.

image

@XMLHexagram
Copy link
Collaborator Author

Closed: ref #221 (comment)

@XMLHexagram XMLHexagram closed this Jan 4, 2025
@XMLHexagram XMLHexagram deleted the fix_ios_color_mode_switch branch January 4, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants