-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): Color mode switch error #223
Conversation
Reviewer's Guide by SourceryThis PR fixes an issue with the color mode switch on iOS devices. The micaBackgroundColor is now used if the window effect is solid or if the platform is iOS. State diagram for color mode behaviorstateDiagram-v2
[*] --> CheckPlatformAndEffect
CheckPlatformAndEffect --> UseMicaBackground: Platform is iOS OR
WindowEffect is Solid
CheckPlatformAndEffect --> UseTransparent: Other cases
UseMicaBackground --> [*]
UseTransparent --> [*]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @XMLHexagram - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more detailed PR description that explains:
- What color mode switch error was occurring on iOS
- How this fix resolves the issue
- How to verify the fix works
- Why this needs to be merged before PR fix(iOS): Support secure bookmarks #221
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@@ -390,7 +390,7 @@ class _RuneState extends State<Rune> { | |||
final theme = FluentTheme.of(context); | |||
|
|||
Widget content = Container( | |||
color: appTheme.windowEffect == WindowEffect.solid | |||
color: (appTheme.windowEffect == WindowEffect.solid || Platform.isIOS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed: ref #221 (comment) |
Plz review and merge this PR before #221
Summary by Sourcery
Bug Fixes: