fix: Color space issue for skybox

Losses · Jun 10, 2024 · 97f9f91 · 97f9f91
1 parent 78a711f
commit 97f9f91
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/components/Grass.ts b/src/components/Grass.ts
@@ -69,9 +69,6 @@ const GRID_SEGMENTS_Y = Math.ceil(SEGMENTS_BASE_Y * VISUAL_LOAD.value);
 export const GRID_WIDTH = 80;
 export const GRID_HEIGHT = Math.PI / 8 + 0.1;
 
-GRASS_BASE_COLOR.setHex(THEME_VALUE.value.grassBase, THREE.LinearSRGBColorSpace);
-GRASS_TIP_COLOR.setHex(THEME_VALUE.value.grassTip, THREE.LinearSRGBColorSpace);
-
 export const Grass = (tracker: ResourceTracker) => {
    const positions = createRectanglePositions(
       GRASS_WIDTH,

diff --git a/src/manager/GrassManager.ts b/src/manager/GrassManager.ts
@@ -66,7 +66,7 @@ export const GrassManager = (
       );
 
       material.uniformsNeedUpdate = true;
-   });
+   }, true);
 
    return {};
 };
diff --git a/src/manager/SkyBoxManager.ts b/src/manager/SkyBoxManager.ts
@@ -1,4 +1,4 @@
-import type * as THREE from 'three';
+import * as THREE from 'three';
 
 import type { ResourceTracker } from '../utils/ResourceTracker';
 import { SkyBox } from '../components/SkyBox';
@@ -15,8 +15,8 @@ export const SkyBoxManager = (
    THEME_VALUE.subscribe((theme) => {
       const uniforms = skyBox.material.uniforms;
 
-      (uniforms.color2.value as THREE.Color).setHex(theme.sky0);
-      (uniforms.color1.value as THREE.Color).setHex(theme.sky1);
+      (uniforms.color2.value as THREE.Color).setHex(theme.sky0, THREE.LinearSRGBColorSpace);
+      (uniforms.color1.value as THREE.Color).setHex(theme.sky1, THREE.LinearSRGBColorSpace);
 
       skyBox.material.uniformsNeedUpdate = true;
    }, true);