fix(IRC): handle expected websocket error when leaving last room #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the IRCConnection 'parts' from the last room they were in, the websocket gets disconnected and throws the next time we try to call receive().
LosFarmosCTL
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Nice catch, this looks good to me!
In general, maybe the last remaining connection in a pool shouldn't be disconnected even when the last channel is PARTed, I haven't thought about that when writing the initial implementation, but this change would still be needed regardless for any additional connections that are created.
Cool! Thanks for merging 😄
Well, I'm not sure we can actually control that. From what I've seen is Twitch that is closing the socket 😓 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya! Bringing a quick one here for review.
I was noticing some unexpected states in my app and I was able to pin the issue down to some errors being thrown by
IRCConnectionthat were not being handled upstream. The specific error I was seeing happened because it turns out that when theIRCConnection'parts' from the last room it was connected to, the websocket gets disconnected. This causes the next call towebsocket.receive()to throw an error.I have added some logic to handle this and also made sure to bubble up any unhandled errors so they don't get 'eaten' in the
Taskcalls and they can be properly handled by the client. Let me know what you think!Cheers.