Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix for the missing close icon and warnings under Unity 2023 #398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Eideren
Copy link
Contributor

@Eideren Eideren commented Jul 15, 2024

yeh

Unity removed that internal style in version 2023.3.0b10 at least

@nukeandbeans
Copy link
Collaborator

A cleaner solution to this would be to use (Texture2D)EditorGUIUtility.TrIconContent( "d_clear@2x" ).image to use the built-in icon. This will remove the need for extra icons in the package, and use the icons built into Unity. That icon is present all the way back to 2021.3, and probably before. Most likely won't go away because it's used in other styles (search clear boxes, for example).

I would also like to mention that I am currently in the process of rewriting all of the UI to use the new Overlays system, which will move the minimum version up to 2021.3, and most likely cause this PR to be short-lived. Progress on this can be tracked in the RCSG Discord. I'll leave this PR up for everyone else to see how to fix it for themselves, but for now I won't merge this (and other PRs, most likely). I do appreciate the effort, though. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants