perf: add back fullsweep_after to Task.Supervisor #2247
Closed
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the spawn_opt gets forwarded to the underlying process |
chasers
requested changes
Nov 4, 2024
|
As discussed, leaving this open for observation. |
Ziinc
force-pushed
the
perf/add-back-task-supervisor-fullsweep-after
branch
from
2907ea9 to
786d662
Compare
chasers
approved these changes
Nov 7, 2024
|
Closing as memory isn't an issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back spawn_opt for Task.Supervisor, prevents garbage buildup.
Was removed in 40db716#diff-14a0c2e2cb2fe12cfea0794ab7c068ea2f25fa332f3fb7e0351e9d63b0266adfL81