ft: DataDog adaptor #2020
Merged
ft: DataDog adaptor #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
ft/datadog-adaptor
branch
4 times, most recently
from
06f0644 to
4cc6f32
Compare
hauleth
force-pushed
the
ft/datadog-adaptor
branch
from
4cc6f32 to
a688a23
Compare
hauleth
force-pushed
the
ft/datadog-adaptor
branch
2 times, most recently
from
fa87305 to
e345d50
Compare
Ziinc
requested changes
Apr 11, 2024
hauleth
force-pushed
the
ft/datadog-adaptor
branch
7 times, most recently
from
610eba5 to
904fb27
Compare
hauleth
force-pushed
the
ft/datadog-adaptor
branch
from
e7e0946 to
8340e4b
Compare
hauleth
force-pushed
the
ft/datadog-adaptor
branch
from
8340e4b to
2255879
Compare
Ziinc
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Implementation looks good, small nits, good to merge after they're cleared.
For further improvements down the road, we'd need to consider their batch sizes:
we'd likely need configurable max batch size and max batch length for webhook adaptor, similar to what BQ adaptor is doing
will backlog this until their api starts rejecting us
Ziinc
force-pushed
the
ft/datadog-adaptor
branch
2 times, most recently
from
c582a09 to
a76d985
Compare
Ziinc
previously approved these changes
Apr 25, 2024
hauleth
force-pushed
the
ft/datadog-adaptor
branch
from
cbd8994 to
5afab89
Compare
|
@Ziinc what happened with all these commits? |
|
Ah I rebased it in the log drain PR |
|
Should I clean this up with my local state?
…--
Łukasz Niemier
***@***.***
|
|
Have pushed up the region changes Will need to do some more testing before merge
|
This introduces wrapper adaptor over Webhook adaptor to send logs to DataDog HTTP log ingest endpoint.
Ziinc
approved these changes
May 13, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces wrapper adaptor over Webhook adaptor to send logs to
DataDog HTTP log ingest endpoint.