Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use OTP 26 #1719

Merged
merged 3 commits into from
Oct 6, 2023
Merged

chore: use OTP 26 #1719

merged 3 commits into from
Oct 6, 2023

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Oct 4, 2023

  • chore: update Rustler to version 0.29.x
  • chore: replace calls to Logger.warn with Logger.warning

@hauleth
Copy link
Contributor Author

hauleth commented Oct 4, 2023

I haven't updated .tool-versions (as I do not use that file personally) so I do not know if it should be handled by me, or someone else can do that.

@hauleth hauleth marked this pull request as ready for review October 5, 2023 11:15
@Ziinc
Copy link
Contributor

Ziinc commented Oct 5, 2023

@hauleth .tool-versions would need to be bumped to otp26 as we use asdf for environment management.

@Ziinc
Copy link
Contributor

Ziinc commented Oct 5, 2023

would need the tool-versions changes + mix format

@hauleth
Copy link
Contributor Author

hauleth commented Oct 5, 2023

It seems that there is flaky test.

@hauleth hauleth force-pushed the chore/use-otp-26 branch 6 times, most recently from 2a91a69 to f570d46 Compare October 6, 2023 12:11
@hauleth
Copy link
Contributor Author

hauleth commented Oct 6, 2023

Finally it pass everything. Merge it and I will update #1715 on top and it will pass as well.

@chasers chasers merged commit e48c610 into Logflare:staging Oct 6, 2023
3 checks passed
@chasers
Copy link
Contributor

chasers commented Oct 6, 2023

@hauleth merged!

@hauleth hauleth deleted the chore/use-otp-26 branch October 11, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziinc Ziinc Ziinc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauleth @Ziinc @chasers