Init upon readystate interactive instead of complete #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidely
requested changes
May 23, 2024
Co-authored-by: Laura van Helvoort <[email protected]>
iMarbot
approved these changes
May 23, 2024
|
Wouldn't this double-initialize and add multiple event handlers? |
|
Why would it double initialize? Array.includes() is not a loop, just checks if the value passed is in the array and goes in or stays out. |
|
Ah nvm, I had a brainfart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes the event handlers & local storage update as soon as document is interactive.
As proposed by R1ch: https://discord.com/channels/93055209017729024/372075546231832576/1242894633139437688
Only tested by letting a userscript execute the JS since i don't have a dev wiki.