Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(match2): error when using ShowBracket #5202

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(match2): error when using ShowBracket #5202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2210fad
fix(match2): error when using ShowBracket
Rathoz Dec 12, 2024
9f04389
add comment
Rathoz Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions components/match2/commons/match_group_input.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,13 @@ function MatchGroupInput.applyOverrideArgs(matches, args)
end
end

---@param matches {match2opponents: table[]}[]
---@param matches {match2opponents: table[]?, opponents: table[]?}[]
---@return integer
function MatchGroupInput.getMaxOpponentCount(matches)
return Array.reduce(matches, function(cur, match)
return math.max(#match.match2opponents, cur)
-- If the match comes from ShowBracket then it's opponents, otherwise it's match2opponents
-- Which is stupid, and needs to be fixed
return math.max(#(match.match2opponents or match.opponents or {}), cur)
end, 0)
end

Expand Down
Loading