feat(match2): Support for Marvel Rivals #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rathoz
reviewed
Dec 10, 2024
components/match2/wikis/marvelrivals/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Dec 10, 2024
components/match2/wikis/marvelrivals/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Dec 10, 2024
components/match2/wikis/marvelrivals/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Dec 10, 2024
Rathoz
reviewed
Dec 10, 2024
Rathoz
reviewed
Dec 10, 2024
components/match2/wikis/marvelrivals/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Dec 10, 2024
components/match2/wikis/marvelrivals/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
hjpalpha
reviewed
Dec 10, 2024
components/match2/wikis/marvelrivals/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
hjpalpha
approved these changes
Dec 10, 2024
Rathoz
reviewed
Dec 11, 2024
components/match2/wikis/marvelrivals/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
Rathoz
reviewed
Dec 11, 2024
components/match2/wikis/marvelrivals/get_match_group_copy_paste_wiki.lua
Show resolved
Hide resolved
Rathoz
reviewed
Dec 11, 2024
components/match2/wikis/marvelrivals/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
outside the obvious of winner vs finished, the rest of input still works just fine
Rathoz
reviewed
Dec 16, 2024
components/match2/wikis/marvelrivals/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
Rathoz
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New Wiki: Marvel Rivals
the game is basically Overwatch but Marvel, however the Match2 port here starts with clean COD wiki port with no changes outside removing Mode icon calls for now, because the game has multiple modes, but doesnt have mode icons in the game. (Fortunately no one map is played on two modes)
Includes Info module as well
How did you test this change?
https://liquipedia.net/marvelrivals/User:Hesketh2/Match2_Test