feat(match2): Support the use of playall instead of bestof

[fregerson]

Summary

Attempted to create and store a new variable playall for Match Series that requires teams to play out a fixed number of games (instead of a bestof)

How did you test this change?

dev

[Rathoz]

How commons would thise be? If it's only a few matches one can always set finished=false for the duration

[fregerson]

How commons would thise be? If it's only a few matches one can always set finished=false for the duration

Used for quite a number of recent non-official tournaments, we have not had the manpower to cover many of those, but thought it was something that could be used as an alternative for best of

[Rathoz]

Suggested change

	function MatchGroupInputUtil.allHasBeenPlayed(playall, opponents)
	local scoreSum = Array.reduce(opponents, function(sum, opponent) return sum + (opponent.score or 0) end, 0)
	return scoreSum >= playall
	end
	function MatchGroupInputUtil.allHasBeenPlayed(games)
	return Array.all(games, function(game) return game.finished end)
	end

Wouldn't this do it?

[fregerson]

Hmm you are right in this case then, shouldn't we just refactor playall to be a true/false variable, since the number of games for bestof is calculated by number of maps that are in the input?

[hjpalpha]

not the case on all wikis fwiw

[fregerson]

Hmm I mean like the use of PlayAll is currently only calculated if PlayAll is non-zero? And thus far this has no representation, for example, in making Ticker use {{Abbr/PaX}} instead of {{Abbr/BoX}}

[Rathoz]

I like the true/false version personally

[fregerson]

Tried it that way instead in the below commit

[fregerson]

Ah wait a second, breaks when no maps are provided :/

[fregerson]

Reverted to the proposal where playall is a boolean, and the bestof is used to determine how many games are played. Not sure if this is the direction