Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matchTable): support redirected pages that are not set in the team templates #5134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjpalpha
Copy link
Collaborator

Summary

currently in some edge cases matchTable doesn't retrieve the wanted matches.
mentioned on discord: https://discord.com/channels/93055209017729024/268719633366777856/1309935673842864129

cause of this:

  • matchTable retrieves the page names from (historical) TeamTemplate(s)
  • there exists a (page) redirect from (at least) one of the pages set in the team template to a page that is not among the pages listed in the team templates
  • the match stores them redirect resolved
  • hence the condition will never meet what is stored in matches

This PR makes it so that conditions in matchTable gets adjusted so that it also checks for resolve redirected versions.

How did you test this change?

dev

@hjpalpha hjpalpha added the c: match_table Match Table for on /Matches pages or "Recent Matches" sections label Nov 24, 2024
@hjpalpha hjpalpha requested a review from Rathoz November 24, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: match_table Match Table for on /Matches pages or "Recent Matches" sections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant