fix(Opponent): opponentname condition in PlayerExtCustom faulty #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Nov 4, 2024
Co-authored-by: hjpalpha <[email protected]>
hjpalpha
approved these changes
Nov 4, 2024
hjpalpha
changed the title
|
Would it not be better to set in match2 to pagify? |
might cause issues in other places, e.g. GTL etc |
That's going through legacy, so just need to make sure it's kept the same there as today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opponent.resolvegsubs for underscores before calling to this function, butopponentnameis stored with spaces.How did you test this change?
/dev