Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from female to game changer on valorant #4856

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 13, 2024

Summary

As per request on discord switch |female= to |gc= and also adjust wiki var, category and storage.

How did you test this change?

dev

After merge:

@FO-nTTaX
Copy link
Member

should probably standardize this on either gamechanger or gamechangers, not have a mix

@hjpalpha hjpalpha requested a review from Rathoz October 18, 2024 11:06
@hjpalpha hjpalpha marked this pull request as ready for review October 21, 2024 08:22
@Rathoz Rathoz changed the title feat(several): switch from female to game changer on valorant feat): switch from female to game changer on valorant Oct 22, 2024
@Rathoz Rathoz changed the title feat): switch from female to game changer on valorant feat: switch from female to game changer on valorant Oct 22, 2024
@Rathoz
Copy link
Collaborator

Rathoz commented Nov 11, 2024

It's always called game changers, so would be better with that version (eg https://liquipedia.net/valorant/VCT/2024/Game_Changers_Championship#Results )

@hjpalpha
Copy link
Collaborator Author

It's always called game changers, so would be better with that version (eg https://liquipedia.net/valorant/VCT/2024/Game_Changers_Championship#Results )

appended the s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants