Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(match2): MLBB MGI #4827

Merged
merged 3 commits into from
Oct 9, 2024
Merged

refactor(match2): MLBB MGI #4827

merged 3 commits into from
Oct 9, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 7, 2024

Summary

How did you test this change?

@Rathoz Rathoz added c: match2 g: mobilelegends Mobile Legends: Bang Bang labels Oct 7, 2024
@Rathoz Rathoz requested a review from hjpalpha October 7, 2024 19:18
@Rathoz Rathoz requested a review from hjpalpha October 9, 2024 10:15
hjpalpha
hjpalpha approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay for me,

eventually we should standardize pick/ban data in extradata
would make writing consumers way easier

@Rathoz
Copy link
Collaborator Author

Rathoz commented Oct 9, 2024

okay for me,

eventually we should standardize pick/ban data in extradata would make writing consumers way easier

Picks should go into what is now participants, bans will probably get a new field

@Rathoz Rathoz merged commit 51bc045 into main Oct 9, 2024
5 checks passed
@Rathoz Rathoz deleted the mgi-mlbb branch October 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjpalpha hjpalpha hjpalpha approved these changes

Assignees
No one assigned
Labels
c: match2 g: mobilelegends Mobile Legends: Bang Bang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rathoz @hjpalpha