Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timezone) Add new version of Alma-Ata Time #4487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mbergen
Copy link
Collaborator

@mbergen mbergen commented Aug 7, 2024

Summary

Kazakhstan unified their timezone on march 1st, shifting the ALMT time to UTC+5.

The idea would be to add two versions (i happily take ideas on the name) of ALMT time and bot-convert usages before that date to the version with +6.

How did you test this change?

Just data

Kazakhstan unified their timezone on march 1st, shifting the ALMT time to UTC+5.

The idea would be to add two versions (i happily take ideas on the name) of ALMT time and bot-convert usages before that date to the version with +6.
@mbergen mbergen added the data Changes to data modules label Aug 7, 2024
@mbergen mbergen requested review from Rathoz, iMarbot and hjpalpha August 7, 2024 12:49
@Rathoz
Copy link
Collaborator

Rathoz commented Aug 8, 2024

Who'll take it uppon themself to do the bot run?

@iMarbot
Copy link
Collaborator

iMarbot commented Aug 8, 2024

Can we not just use stop using ALMT and start using AQTT going forward?

@Rathoz
Copy link
Collaborator

Rathoz commented Aug 8, 2024

Or a new Kazakh time?

@mbergen
Copy link
Collaborator Author

mbergen commented Aug 8, 2024

Who'll take it uppon themself to do the bot run?

Can do once i know which name to use

@mbergen
Copy link
Collaborator Author

mbergen commented Aug 8, 2024

Can we not just use stop using ALMT and start using AQTT going forward?

ALMT is still a valid entry in the tzinfo database, so this would depend on every editor to know we have an exception for it

@Rathoz
Copy link
Collaborator

Rathoz commented Aug 8, 2024

Well, PARIS (Europe/Paris) is a valid entry in tzinfo as well, doesn't mean we have support for it :D Just so we don't need to have Asia/Almaty (ALMT) support

@mbergen
Copy link
Collaborator Author

mbergen commented Aug 8, 2024

The thing is we already have ALMT support tho - so if someone sees the abbreviation template working, they'll think it can be used

@iMarbot
Copy link
Collaborator

iMarbot commented Aug 8, 2024

The thing is we already have ALMT support tho - so if someone sees the abbreviation template working, they'll think it can be used

Did the country actually change ALMT to be +5 or did they just move people off ALMT (+6) and move them to some +5 timezone? I make no claims to know the truth, but I went on timeanddate.com and it still claims ALMT itself is +6.
image

@mbergen
Copy link
Collaborator Author

mbergen commented Aug 8, 2024

From the IANA tz database:

Zone Asia/Almaty 5:07:48 - LMT 1924 May 2 # or Alma-Ata
5:00 - +05 1930 Jun 21
6:00 RussiaAsia +06/+07 1991 Mar 31 2:00s
5:00 RussiaAsia +05/+06 1992 Jan 19 2:00s
6:00 RussiaAsia +06/+07 2004 Oct 31 2:00s
6:00 - +06 2024 Mar 1 0:00
5:00 - +05

So to my understanding it was changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Changes to data modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants