feat(participants): Allow teams in participants table

[iMarbot]

Summary

Want to be able to use this table for teams too as it's compact and handy for displaying lists of teams that are participating (sometimes grouped) without needing to fill out team cards that have specific seeding assigned to them.

hjpa suggested disable storage for teams, but actually it would be useful to have it working for there too for the reason I mentioned above. Can still manually disable it if not used strictly for creating LPDB placements.

(sorry for awful screenshot, W11 HDR 👍 )

How did you test this change?

/dev on https://liquipedia.net/counterstrike/index.php?title=Test&oldid=2704673

[hjpalpha]

lgtm if tested
please also test on sc2/sc/wc/stormgate due to /custom being used there

[iMarbot]

lgtm if tested please also test on sc2/sc/wc/stormgate due to /custom being used there

Those 3 override readEntry() with their own function which still has the assert on not being team opponents. I can change it there too if you want, but right now they should continue to function as they have been previously.

[hjpalpha]

lgtm if tested please also test on sc2/sc/wc/stormgate due to /custom being used there

Those 3 override readEntry() with their own function which still has the assert on not being team opponents. I can change it there too if you want, but right now they should continue to function as they have been previously.

imo if we allow it on commons we should allow it on the customs too

[Rathoz]

I'm skeptical, this would have significant impact on the functioning on player's of the team in other places. Such as earnings of player, player results, player matches, upcoming matches of player, upcoming tournaments of player.

[iMarbot]

I'm skeptical, this would have significant impact on the functioning on player's of the team in other places. Such as earnings of player, player results, player matches, upcoming matches of player, upcoming tournaments of player.

As I explained, this is not intended for permanent use on tournament pages. It's for temporary use where teams cannot yet be placed in teamcards for whatever reason.

The only one of those actually affected would be upcoming tournaments of player, something which few wikis support currently. And again, it would only be until team cards are possible to be filled out.

Also just want to be able to use the functionality of a wikitable that fills out with teams split into sections without storage too.

[iMarbot]

Pushed change to all the customs and added fallback to not index entries table by nil when team template for the opponent doesn't exist and hence no name field.

Mixing players and teams on the custom wikis does disable the race columns, but I assume that's desirable behaviour?

[hjpalpha]

Pushed change to all the customs and added fallback to not index entries table by nil when team template for the opponent doesn't exist and hence no name field.

hmm, not sure we should do that
personally i always let it error with an error that says it doesn't exist
but not super important imo

Mixing players and teams on the custom wikis does disable the race columns, but I assume that's desirable behaviour?

yes that is intended faction/race columns disapear once you have mixed opponent types
they also disapear once you have a duo/trio/quad/archon opponent listed

[iMarbot]

hmm, not sure we should do that
personally i always let it error with an error that says it doesn't exist
but not super important imo

Easier for casual users to understand what broken with the first one. Sure, we can add error message explaining more in the second, but we do the same on brackets where we don't break display for a missing TT.

[iMarbot]

@Rathoz Any concerns with this still, or?