Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): run type checking via LuaLS in pipeline #3640

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(ci): run type checking via LuaLS in pipeline #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/luacheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,16 @@ jobs:
with:
report_paths: 'busted.xml'
check_name: 'Test Report'

lua-type-check:
name: Type Check Code Base
runs-on: ubuntu-latest

steps:
- name: Checkout Code
uses: actions/checkout@v3

- name: Type Check Code Base
uses: mrcjkb/[email protected]
with:
checklevel: Error
Copy link
Collaborator

@mbergen mbergen Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is not checking at all since it is trying to check a directory "lua" which we do not have?
lua-language-server --check "/home/runner/work/Lua-Modules/Lua-Modules/lua" --logpath=. --checklevel=Error
If that is the case, it's also wrong on the action repo itself.

Suggested change
checklevel: Error
checklevel: Error
directories: |
./

Loading