Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update squad.lua #3349

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Update squad.lua #3349

merged 5 commits into from
Jan 10, 2024

Conversation

salle
Copy link
Contributor

@salle salle commented Oct 3, 2023

Removing title row from most tables as they almost always live under section headings with a synonymous name.

Summary

How did you test this change?

Removing title row from most tables as they almost always live under section headings with a synonymous name.
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it intended that former headers get removed?

components/squad/commons/squad.lua Outdated Show resolved Hide resolved
@hjpalpha
Copy link
Collaborator

hjpalpha commented Oct 3, 2023

mind: linter is saying you have lines with only white space: 60, 65, 71

@salle
Copy link
Contributor Author

salle commented Oct 13, 2023

is it intended that former headers get removed?

Yes, both these headers have external headers as standard across most if not all pages.

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tested

@salle
Copy link
Contributor Author

salle commented Oct 31, 2023

lgtm if tested

image
Tested it on Dota and it looked fine.

@hjpalpha hjpalpha requested a review from Rathoz October 31, 2023 09:52
@Rathoz Rathoz merged commit 2199c3e into main Jan 10, 2024
2 checks passed
@Rathoz Rathoz deleted the salle-patch-1 branch January 10, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants