Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & move gamersclub to CS custom links #3347

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

iMarbot
Copy link
Collaborator

@iMarbot iMarbot commented Oct 2, 2023

Summary

Gamers Club as a platform now provides VAL, LoL, Fortnite, and WR on top of CS(:GO) so having it default to cs:go in the main links seemed wrong to me. Also, they changed their website structure from csgo to cs, so I updated that too. And in case they move to some new subdomain instead of csgo.gamersclub.gg, also moved back to gamersclub.com.br which should redirect to the correct CS(:GO) place regardless.

How did you test this change?

Just some data.

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise lgtm
should the ones for val etc be added too? (am on mobile so if they already overwrite them in custom i didn't see it)

@iMarbot
Copy link
Collaborator Author

iMarbot commented Oct 2, 2023

should the ones for val etc be added too? (am on mobile so if they already overwrite them in custom i didn't see it)

I don't think they use them really, but I moved it as a precaution in case they want to in the future, since gamersclub is not a game-specific name like dotabuff or apexlegendsstatus (for example).

@Rathoz Rathoz merged commit ba1b5e9 into main Oct 3, 2023
2 checks passed
@Rathoz Rathoz deleted the cs-update-gamersclub-link branch October 3, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants