Set page category when requiring dev modules #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hjpalpha <[email protected]>
hjpalpha
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets
Pages using dev modulescategory on any pages using (or trying to use) dev modules via Lua invoke or Lua import. Seems to be something we want as seen on discord (https://discord.com/channels/93055209017729024/874304000718172200/1157311906042875984), so added it with help of hjpa. Only applies to namespaces that are considered "main" by the namespace module.How did you test this change?
Tested on
/devmodule using temporary Lua/dev invoke template in userspace and mainspace.