Add pseudo game "CS:GO/CS2" to cs wiki #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#fuckESL |
Can't really blame them for not having a public release date to plan with... |
well the comment might also be due to what BS they do in sc2 atm |
|
Hm, it adds a lot of complexity for a small, short term gain, is it really needed? |
Complexity in what way? Also, I wouldn't call it short term because this isn't just while a tournament is ongoing, this is to accurately record that the tournament is and was played on two different games. |
|
RFM imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because ESL decided to move already ongoing tournaments from CS:GO to CS2 (😠), we now have to deal with this. I thought about adding multiple game support to the infobox but that would require changing the base infobox too and not just CS custom. Also, what would we even do for the
tournament_gamevar?? Would have to have like a switch date or something and maybe multiple vars, and then have to add display support for that in other modules too... so yeah, nope.Instead just making this not really real game for the purpose. Then will override game per-match or using vardefine somewhere on the pages.
How did you test this change?
/dev and then pushed to live also as needed ASAP.