Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force disable merging reset into normal match #3336

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

hjpalpha
Copy link
Collaborator

Summary

Force disable merging reset into normal match

How did you test this change?

live

Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, until rework match summeries?

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Oct 2, 2023

LGTM, until rework match summeries?

before please

it is needed so we can rework stuff

after rework is done (i.e. all is merged) i will clean up the whole function

@Rathoz
Copy link
Collaborator

Rathoz commented Oct 2, 2023

LGTM, until rework match summeries?

before please

I meant once the Match Summaries have been reworked this no longer needed?

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Oct 2, 2023

LGTM, until rework match summeries?

before please

I meant once the Match Summaries have been reworked this no longer needed?

yes

@Rathoz Rathoz merged commit 071e6b0 into main Oct 2, 2023
2 checks passed
@Rathoz Rathoz deleted the hjpalpha-patch-8-1 branch October 2, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants