Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isEmpty function to Module:Opponent #3258

Merged
merged 14 commits into from
Sep 14, 2023
Merged

Add isEmpty function to Module:Opponent #3258

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
16a7443
add isEmpty and isBye functions to opponent module
hjpalpha Sep 3, 2023
ff9cb6f
also check against blank opponents
hjpalpha Sep 3, 2023
b9ccd6c
trailing whitespace
hjpalpha Sep 3, 2023
5ca66ad
Update opponent.lua
hjpalpha Sep 3, 2023
a12e6e1
typo
hjpalpha Sep 3, 2023
42a4e7f
Update opponent.lua
hjpalpha Sep 3, 2023
94b4854
Update components/opponent/commons/opponent.lua
hjpalpha Sep 3, 2023
26adc4c
split out into #3264
hjpalpha Sep 5, 2023
c52e172
catch team tbd opponents
hjpalpha Sep 5, 2023
07bec7b
Merge branch 'main' into add-isEmpty-and-isBye-functions-to-opponent-…
Rathoz Sep 5, 2023
5abe7c0
switch to alternative
hjpalpha Sep 11, 2023
6d09ecb
add some comments
hjpalpha Sep 12, 2023
2191c65
Update components/opponent/commons/opponent.lua
hjpalpha Sep 12, 2023
8717936
Update opponent.lua
hjpalpha Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/opponent/commons/opponent.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ end
---@param opponent standardOpponent?
---@return boolean
function Opponent.isEmpty(opponent)
if not opponent or not opponent.type or Table.deepEquals(opponent, Opponent.blank(opponent.type)) then
if not opponent or not opponent.type or
(Table.deepEquals(opponent, Opponent.blank(opponent.type)) and not Opponent.isTbd(opponent)) then
Rathoz marked this conversation as resolved.
Show resolved Hide resolved
return true
end

Expand Down