-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match2 for Apex Legends #3255
match2 for Apex Legends #3255
Conversation
02aaf33
to
c0c3ca2
Compare
dfdac28
to
70d3ac4
Compare
Not all CSS and JS is completed yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review for the 2 commons modules on tablet
components/match2/commons/match_group_display_bracket_as_list.lua
Outdated
Show resolved
Hide resolved
components/match2/commons/match_group_display_bracket_as_list.lua
Outdated
Show resolved
Hide resolved
components/match2/commons/match_group_display_bracket_as_list.lua
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing annos here and there obviously, but apart from that do not see any issues on tablet
generally: when more of the ffa/BR wikis get match2 i think we can move large parts of the apex ms to a commons module for easier building further BR MS
(will probably switch sc/sc2 ffa MS over to something similar to this once such a commons module exists)
1220983
to
d2f4b12
Compare
That's the plan |
components/match2/commons/match_group_display_horizontallist.lua
Outdated
Show resolved
Hide resolved
components/match2/commons/match_group_display_horizontallist.lua
Outdated
Show resolved
Hide resolved
components/match2/commons/match_group_display_horizontallist.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/apexlegends/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
59384c4
to
f8c7abb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still have some #TODO
in here^^
code wise lgtm for first 4 modules
will review the MS one later
components/match2/wikis/apexlegends/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
CSS and JS are still WIP |
Summary
match2 for Apex, still a bit WIP as css and js are not completd. there will be future PRs with some minor tweaks for sure
How did you test this change?
User space