Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match2 for Apex Legends #3255

Merged
merged 55 commits into from
Oct 16, 2023
Merged

match2 for Apex Legends #3255

merged 55 commits into from
Oct 16, 2023

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Sep 1, 2023

Summary

match2 for Apex, still a bit WIP as css and js are not completd. there will be future PRs with some minor tweaks for sure

How did you test this change?

User space

@Rathoz Rathoz added c: match2 g: apex Apex Legends labels Sep 1, 2023
@Rathoz Rathoz force-pushed the match2-battle-royale branch from 02aaf33 to c0c3ca2 Compare September 7, 2023 13:53
@Rathoz Rathoz changed the title match2 display for Battle Royales match2 for Apex Legends Sep 21, 2023
@Rathoz Rathoz force-pushed the match2-battle-royale branch 3 times, most recently from dfdac28 to 70d3ac4 Compare September 21, 2023 07:21
@Rathoz Rathoz requested a review from hjpalpha September 21, 2023 07:32
@hjpalpha
Copy link
Collaborator

not sure if it might be cache, but on tablet i see some issues:
B162B9B6-2572-49C4-B2B5-B39F168842CB
BF87BC60-893F-4A5F-8812-F07D030BB714

https://liquipedia.net/apexlegends/User:Rathoz

@Rathoz
Copy link
Collaborator Author

Rathoz commented Sep 21, 2023

Not all CSS and JS is completed yet

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review for the 2 commons modules on tablet

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing annos here and there obviously, but apart from that do not see any issues on tablet

generally: when more of the ffa/BR wikis get match2 i think we can move large parts of the apex ms to a commons module for easier building further BR MS
(will probably switch sc/sc2 ffa MS over to something similar to this once such a commons module exists)

@Rathoz Rathoz force-pushed the match2-battle-royale branch from 1220983 to d2f4b12 Compare September 21, 2023 16:15
@Rathoz
Copy link
Collaborator Author

Rathoz commented Sep 22, 2023

generally: when more of the ffa/BR wikis get match2 i think we can move large parts of the apex ms to a commons module for easier building further BR MS

That's the plan

@Rathoz Rathoz requested a review from hjpalpha September 25, 2023 10:52
@Rathoz Rathoz force-pushed the match2-battle-royale branch from 59384c4 to f8c7abb Compare October 4, 2023 12:25
@Rathoz Rathoz requested a review from hjpalpha October 5, 2023 08:01
@Rathoz Rathoz marked this pull request as ready for review October 5, 2023 08:04
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will panel-table get overflow-x: auto for mobile?
or something else so that it can be viewed on mobile properly?
also the right arrow icon is kinda hard to see and
it isn't present on the game tables

Screenshot 2023-10-05 105925

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still have some #TODO in here^^

code wise lgtm for first 4 modules
will review the MS one later

@Rathoz
Copy link
Collaborator Author

Rathoz commented Oct 6, 2023

will panel-table get overflow-x: auto for mobile? or something else so that it can be viewed on mobile properly? also the right arrow icon is kinda hard to see and it isn't present on the game tables

CSS and JS are still WIP

@Rathoz Rathoz requested a review from hjpalpha October 9, 2023 07:35
@Rathoz Rathoz merged commit 0ee26d3 into main Oct 16, 2023
2 checks passed
@Rathoz Rathoz deleted the match2-battle-royale branch October 16, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants