AoE: Infobox player bugfixes #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since we want to store pagfenames with underscore in the future imo already prep the module for the switch and query for |
Rathoz
approved these changes
Feb 14, 2023
|
i mean to actually have them as an OR condition not just replacing them see e.g. https://github.com/Liquipedia/Lua-Modules/blob/main/components/infobox/wikis/starcraft2/infobox_person_player_custom.lua as reference: #1802 |
|
Should i add another bugfix in here or a separate PR? |
mbergen
changed the title
hjpalpha
approved these changes
Feb 15, 2023
components/infobox/wikis/ageofempires/infobox_person_player_custom.lua
Outdated
Show resolved
Hide resolved
hjpalpha
approved these changes
Feb 15, 2023
Rathoz
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without resolved ID, querying would fail for lowercased IDs.
Removing the pagename as that doesn't work in userspace and ID is mandatory anyways.
Added optional query for pagenames with underscores instead of spaces.
Also changed the array merge to do one after another (otherwise, games might be added multiple times)
How did you test this change?
/dev