Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version of a Mock for Lpdb #2047

Merged
merged 12 commits into from
Oct 19, 2022
Merged

Initial version of a Mock for Lpdb #2047

merged 12 commits into from
Oct 19, 2022

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 11, 2022 •
edited
Loading

Summary

Create a Mock for LPDB. This Mock only supports a limited version of the querying (fetching) from LPDB.

How did you test this change?

@Rathoz Rathoz marked this pull request as draft October 11, 2022 14:18
@Rathoz Rathoz added the chore label Oct 11, 2022
JaspervanRiet
JaspervanRiet reviewed Oct 11, 2022
View reviewed changes
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Show resolved Hide resolved
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb_data.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Outdated Show resolved Hide resolved
standard/mock/mock_lpdb.lua Show resolved Hide resolved
@Rathoz Rathoz marked this pull request as ready for review October 18, 2022 09:28
@Rathoz Rathoz requested a review from hjpalpha October 18, 2022 09:31
hjpalpha
hjpalpha approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay for me
possibly as followup (as already mentioned by vogan and yourself in the comments): using the comparators defined in condition.lua

@Rathoz Rathoz requested a review from hjpalpha October 19, 2022 11:37
@Rathoz
Copy link
Collaborator Author

Rathoz commented Oct 19, 2022

okay for me possibly as followup (as already mentioned by vogan and yourself in the comments): using the comparators defined in condition.lua

#2100

@Rathoz Rathoz merged commit d121cc4 into main Oct 19, 2022
@Rathoz Rathoz deleted the lpdb-mock branch October 19, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaspervanRiet JaspervanRiet JaspervanRiet left review comments

@hjpalpha hjpalpha hjpalpha approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rathoz @JaspervanRiet @hjpalpha