Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): use new lpdb fields #4822

Closed
wants to merge 15 commits into from
Closed

feat(match2): use new lpdb fields #4822

wants to merge 15 commits into from

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 7, 2024

Summary

Resolves #4821

How did you test this change?

/dev on r6

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm if tested

@Rathoz Rathoz requested a review from hjpalpha October 11, 2024 09:17
@Rathoz Rathoz marked this pull request as ready for review October 11, 2024 10:04
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if somewhat tested

@Rathoz Rathoz closed this Nov 7, 2024
@Rathoz Rathoz deleted the new-lpdb-fields branch November 7, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement of "resulttype" and "walkover" Properties in Match2 and Match2Game
2 participants