fix match2 bracket popups in safari on iOS17 (#3326)

This works by avoiding floats in flex items, and instead using an inline flex container
Liquipedia · Sep 27, 2023 · b86d0df · b86d0df
1 parent a854354
commit b86d0df
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/components/match2/wikis/dota2/match_summary.lua b/components/match2/wikis/dota2/match_summary.lua
@@ -318,7 +318,6 @@ function CustomMatchSummary._opponentHeroesDisplay(opponentHeroesData, numberOfH
 			:addClass('brkts-popup-side-color-' .. color)
 			:addClass('brkts-popup-side-hero')
 			:addClass('brkts-popup-side-hero-hover')
-			:css('float', flip and 'right' or 'left')
 			:node(HeroIcon._getImage{
 				hero = opponentHeroesData[index],
 				size = _SIZE_HERO,
@@ -339,6 +338,7 @@ function CustomMatchSummary._opponentHeroesDisplay(opponentHeroesData, numberOfH
 
 	local display = mw.html.create('div')
 		:addClass('brkts-popup-body-element-thumbs')
+		:addClass('brkts-popup-body-element-thumbs-' .. (flip and 'right' or 'left'))
 	for _, item in ipairs(opponentHeroesDisplay) do
 		display:node(item)
 	end

diff --git a/components/match2/wikis/leagueoflegends/match_summary.lua b/components/match2/wikis/leagueoflegends/match_summary.lua
@@ -292,7 +292,6 @@ function CustomMatchSummary._opponentHeroesDisplay(opponentHeroesData, numberOfH
 	for index = 1, numberOfHeroes do
 		local heroDisplay = mw.html.create('div')
 			:addClass('brkts-popup-side-color-' .. color)
-			:css('float', flip and 'right' or 'left')
 			:node(HeroIcon._getImage{opponentHeroesData[index], date = date})
 		if numberOfHeroes == _NUM_HEROES_PICK_SOLO then
 			if flip then
@@ -310,6 +309,7 @@ function CustomMatchSummary._opponentHeroesDisplay(opponentHeroesData, numberOfH
 
 	local display = mw.html.create('div')
 		:addClass('brkts-popup-body-element-thumbs')
+		:addClass('brkts-popup-body-element-thumbs-' .. (flip and 'right' or 'left'))
 		:addClass('brkts-champion-icon')
 
 	for _, item in ipairs(opponentHeroesDisplay) do

diff --git a/components/match2/wikis/splatoon/match_summary.lua b/components/match2/wikis/splatoon/match_summary.lua
@@ -370,7 +370,6 @@ function CustomMatchSummary._opponentWeaponsDisplay(props)
 	local displayElements = Array.map(props.data, function(weapon)
 		return mw.html.create('div')
 			:addClass('brkts-champion-icon')
-			:css('float', flip and 'right' or 'left')
 			:node(WeaponIcon._getImage{
 				weapon = weapon,
 				game = props.game,
@@ -384,6 +383,7 @@ function CustomMatchSummary._opponentWeaponsDisplay(props)
 
 	local display = mw.html.create('div')
 		:addClass('brkts-popup-body-element-thumbs')
+		:addClass('brkts-popup-body-element-thumbs-' .. (flip and 'right' or 'left'))
 
 	for _, item in ipairs(displayElements) do
 		display:node(item)