Skip to content

Commit

Permalink
Add MatchGroup/Input/Custom for Heroes (#3191)
Browse files Browse the repository at this point in the history
* Add MatchGroup/Input/Custom for Heroes

* 1st

Underscores

* 2nd

while match['map'..mapIndex]

* 3rd

* 4th

Attempt the line 85 fix

* Reverts 4th because it didnt actually fixed line 85

* Update components/match2/wikis/heroes/match_group_input_custom.lua

* resolve "value assigned to variable 'map' is unused"

* adjust in place

* split function into several
also
- add some nil catching
- use Table.iter.pairsByPrefix for better code style

* Veto Adjustments

* Cleanup after 3195/97/98

* Update components/match2/wikis/heroes/match_group_input_custom.lua

Co-authored-by: Rikard Blixt <[email protected]>

* Update components/match2/wikis/heroes/match_group_input_custom.lua

Co-authored-by: Rikard Blixt <[email protected]>

* Update components/match2/wikis/heroes/match_group_input_custom.lua

Co-authored-by: Rikard Blixt <[email protected]>

* Update components/match2/wikis/heroes/match_group_input_custom.lua

Co-authored-by: Rikard Blixt <[email protected]>

* Update components/match2/wikis/heroes/match_group_input_custom.lua

Co-authored-by: Rikard Blixt <[email protected]>

* Update components/match2/wikis/heroes/match_group_input_custom.lua

Co-authored-by: Rikard Blixt <[email protected]>

* Cleared MVP cause I cant find the usage

* Brought Back MVP extradata but mvpteam is gone anyways

Have asked editor

- They ok to have |mvp= stay,  it is something they may get to used
- |mvp= was never used because it isnt supported in match1
- no, |mvpteam= isnt in their interest to use

---------

Co-authored-by: hjpalpha <[email protected]>
Co-authored-by: hjpalpha <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
  • Loading branch information
4 people authored Oct 13, 2023
1 parent f48578d commit 7d7cc33
Showing 1 changed file with 576 additions and 0 deletions.
Loading

0 comments on commit 7d7cc33

Please sign in to comment.