Skip to content

Commit

Permalink
fix(match2): unstandardized pick/ban champion size is max (#4925)
Browse files Browse the repository at this point in the history
* fix(match2) Pick/Ban champion icon class on brawlstars

* also add size

* omegastrikers

* cr
  • Loading branch information
mbergen authored Oct 21, 2024
1 parent 5d97477 commit 74026c1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion components/match2/wikis/brawlstars/match_summary.lua
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@ function Brawler:_opponentBrawlerDisplay(brawlerData, numberOfBrawlers, flip, da
for index = 1, numberOfBrawlers do
local brawlerDisplay = mw.html.create('div')
:addClass('brkts-popup-side-color-' .. (flip and 'red' or 'blue'))
:addClass('brkts-champion-icon')
:css('float', flip and 'right' or 'left')
:node(CharacterIcon.Icon{
character = brawlerData[index] or NO_CHARACTER,
class = 'brkts-champion-icon',
date = date,
size = '48px'
})
if index == 1 then
brawlerDisplay:css('padding-left', '2px')
Expand Down
3 changes: 2 additions & 1 deletion components/match2/wikis/clashroyale/match_summary.lua
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,8 @@ function CustomMatchSummary._opponentCardsDisplay(args)
:addClass('brkts-champion-icon')
:node(CharacterIcon.Icon{
character = card,
date = date
date = date,
size = '48px'
})
)
end
Expand Down
3 changes: 2 additions & 1 deletion components/match2/wikis/omegastrikers/match_summary.lua
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,12 @@ function Striker:_opponentStrikerDisplay(strikerData, numberOfStrikers, flip, da
for index = 1, numberOfStrikers do
local strikerDisplay = mw.html.create('div')
:addClass('brkts-popup-side-color-' .. (flip and 'red' or 'blue'))
:addClass('brkts-champion-icon')
:css('float', flip and 'right' or 'left')
:node(CharacterIcon.Icon{
character = strikerData[index] or NO_CHARACTER,
class = 'brkts-champion-icon',
date = date,
size = '48px',
})
if index == 1 then
strikerDisplay:css('padding-left', '2px')
Expand Down

0 comments on commit 74026c1

Please sign in to comment.