Fix insert first and last tooltip in pages navigator view

LinwoodDev · Sep 13, 2023 · a26dc97 · a26dc97
1 parent e99496a
commit a26dc97
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 26 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -341,26 +341,26 @@ jobs:
   #        name: macos-build
   #        path: |
   #          app/build/macos/Build/Products/Release/butterfly.app
-  build-snap:
-    name: Build Snap
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        architecture:
-          - amd64
-    steps:
-      - uses: actions/checkout@v4
-      - uses: docker/setup-qemu-action@v2
-        with:
-          image: tonistiigi/binfmt@sha256:df15403e06a03c2f461c1f7938b171fda34a5849eb63a70e2a2109ed5a778bde
-      - uses: diddlesnaps/snapcraft-multiarch-action@v1
-        id: build
-        with:
-          architecture: ${{ matrix.architecture }}
-      - uses: actions/upload-artifact@v3
-        with:
-          name: butterfly-snap
-          path: ${{ steps.build.outputs.snap }}    
+  # build-snap:
+  #   name: Build Snap
+  #   runs-on: ubuntu-latest
+  #   strategy:
+  #     matrix:
+  #       architecture:
+  #         - amd64
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #     - uses: docker/setup-qemu-action@v2
+  #       with:
+  #         image: tonistiigi/binfmt@sha256:df15403e06a03c2f461c1f7938b171fda34a5849eb63a70e2a2109ed5a778bde
+  #     - uses: diddlesnaps/snapcraft-multiarch-action@v1
+  #       id: build
+  #       with:
+  #         architecture: ${{ matrix.architecture }}
+  #     - uses: actions/upload-artifact@v3
+  #       with:
+  #         name: butterfly-snap
+  #         path: ${{ steps.build.outputs.snap }}    
   deploy:
     runs-on: ubuntu-22.04
     if: github.event_name == 'push'

diff --git a/app/lib/l10n/app_en.arb b/app/lib/l10n/app_en.arb
@@ -517,6 +517,8 @@
   "cut": "Cut",
   "insertBefore": "Insert before",
   "insertAfter": "Insert after",
+  "insertFirst": "Insert first",
+  "insertLast": "Insert last",
   "paste": "Paste",
   "ascending": "Ascending",
   "descending": "Descending",

diff --git a/app/lib/views/pages.dart b/app/lib/views/pages.dart
@@ -132,29 +132,32 @@ class PagesView extends StatelessWidget {
                         ),
                         Row(
                           children: [
-                            IconButton(
+                            IconButton.filledTonal(
                               icon: const PhosphorIcon(
                                   PhosphorIconsLight.arrowUp),
                               tooltip:
                                   AppLocalizations.of(context).insertBefore,
                               onPressed: () => addPage(index),
                             ),
-                            IconButton(
+                            const SizedBox(width: 8),
+                            IconButton.filledTonal(
                               icon: const PhosphorIcon(
                                   PhosphorIconsLight.arrowDown),
                               tooltip: AppLocalizations.of(context).insertAfter,
                               onPressed: () => addPage((index ?? -1) + 1),
                             ),
-                            IconButton(
+                            const SizedBox(width: 8),
+                            IconButton.filledTonal(
                               icon: const PhosphorIcon(
                                   PhosphorIconsLight.arrowLineUp),
-                              tooltip: AppLocalizations.of(context).add,
+                              tooltip: AppLocalizations.of(context).insertFirst,
                               onPressed: () => addPage(0),
                             ),
-                            IconButton(
+                            const SizedBox(width: 8),
+                            IconButton.filledTonal(
                               icon: const PhosphorIcon(
                                   PhosphorIconsLight.arrowLineDown),
-                              tooltip: AppLocalizations.of(context).add,
+                              tooltip: AppLocalizations.of(context).insertLast,
                               onPressed: () => addPage(),
                             ),
                           ],

diff --git a/fastlane/metadata/android/en-US/changelogs/72.txt b/fastlane/metadata/android/en-US/changelogs/72.txt
@@ -31,6 +31,7 @@
 * Fix pack dialog version text field
 * Fix changing styles of label in selection
 * Fix open with for bfly documents on android
+* Fix insert first and last tooltip in pages navigator view
 * Remove view options from undo
 
 View all changes in the blog: https://linwood.dev/butterfly/2.0.0-beta.8