Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable cd supporting lcd and tcd. Expose as standalone API. Solving #34 #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kailian-Jacy
Copy link

Implementation of #34.
Currently works fine for me.

@Kailian-Jacy Kailian-Jacy changed the title feat: configurable cd as param. Expose as standalone API. feat: Configurable cd supporting lcd and tcd. Expose as standalone API. Solving #34 Nov 15, 2024
@LintaoAmons
Copy link
Owner

Thanks!
Quite busy recently, this is very useful~
By the way, do you know if neo-tree can switch the file tree according to the window's pwd after switching by lcd?

README.md Outdated
@@ -69,6 +69,7 @@ return {
| Command | Description |
| -------------------- | --------------------------------------------------------------------------- |
| `CdProject` | change working directory |
| `CdProjectForWindow` | change working directory for current window (:h lcd for more) |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add a new cmd here; I think it should be great to have it as a config option for the CdProject cmd

@Kailian-Jacy
Copy link
Author

Kailian-Jacy commented Nov 24, 2024

I have not tried neo-tree, I'm working with telescope file browser and it works as expected.

I'm not sure what do you mean:

  1. Does neo-tree auto refreshes after switching lcd as switching pwd does?
  2. lcd and pwd(global working directory) which one does neo-tree follows?p

Either way I think it's just neotree issue, if it does not work well with window-wide working directory change, we should raise an issue in neotree project.

@LintaoAmons
Copy link
Owner

Hello, since your branch conflicts with the main branch, I force pushed my changes to this branch.
I think we can simplify the flow by having one single command. Then in the telescope picker, we can use different shortcuts to trigger different cd_cmd.
Next step maybe is let user be able to have their own shortcut to trigger the actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants