Detect endless recursion in domain name #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
LinkTed
commented
Jan 3, 2025
LinkTed
commented
- feat: Detect endless recursion in domain name
- refactor: Resolve elided_name_lifetimes
- chore: Updated dependencies
- ci: Update jobs
The actions-rs/toolchain is not maintained.
The actions-rs/clippy-check is not maintained.
The actions-rs/cargo is not maintained.
- base64 "0.13.0" to "0.22" - bytes "1.2.1" to "1" - hex "0.4.3" to "0.4" - thiserror "1.0.32" to "2" - criterion "0.3.6" to "0.5"
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 91.86% 96.33% +4.46%
==========================================
Files 92 88 -4
Lines 3541 3982 +441
==========================================
+ Hits 3253 3836 +583
+ Misses 288 146 -142 ☔ View full report in Codecov by Sentry. |
Remove name lifetime, because 'a is already elided in Decoder::get_main.
Add a HashSet to detect endless recursion during decoding of a domain name.
Use an iterative instead of a recursive approach in the decoding of domain names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.