-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt width to min-width and changed height to auto to fit the width #3
base: main
Are you sure you want to change the base?
Conversation
Link to issue. |
Shall the readme.md also be updated to increase the minor version with this change? |
Yes, please up the version number by one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this theme is based on this one: https://github.com/linkstackorg/Magic-Kingdom. Might be worth checking how it's solved there |
There are differences in the code by the share.button.css too. The whole info is missing. I personally prefer the solution I build for our instance, I will check later when I have more time to fix it. But that fix makes it usable for the moment for everyone on mobile who is using it. |
Check out #4 |
The design of the buttons are not mobile friendly at the moment.
To make it suitable for smartphones I adopt the brands.css file and changed the lines:
width: 500px;
height 48;
to
min-width: 320px; (looks fine on google pixel 7 and IPhone SE)
height: auto; (To grow with the width and the text automatically)