Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt width to min-width and changed height to auto to fit the width #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

talheim-it
Copy link

@talheim-it talheim-it commented Apr 5, 2024

The design of the buttons are not mobile friendly at the moment.

To make it suitable for smartphones I adopt the brands.css file and changed the lines:

width: 500px;
height 48;

to

min-width: 320px; (looks fine on google pixel 7 and IPhone SE)
height: auto; (To grow with the width and the text automatically)

@talheim-it
Copy link
Author

#1

Link to issue.

@talheim-it
Copy link
Author

Shall the readme.md also be updated to increase the minor version with this change?

@JulianPrieber JulianPrieber linked an issue Apr 5, 2024 that may be closed by this pull request
@JulianPrieber
Copy link
Member

Shall the readme.md also be updated to increase the minor version with this change?

Yes, please up the version number by one.

@JulianPrieber JulianPrieber self-requested a review April 5, 2024 16:45
Copy link
Member

@JulianPrieber JulianPrieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefox_Lz2ERlw0Gf
New version
firefox_c7bxnEtpym
Old version

I think I'd prefer it if we can get the buttons to remain their original max width on Desktop.
If we can get the proper new formatting on mobile and the old formatting on Desktop, I'll merge it. 👍

@JulianPrieber
Copy link
Member

I believe this theme is based on this one: https://github.com/linkstackorg/Magic-Kingdom.
It doesn't seem to have the problem, not sure when this was introduced.

Might be worth checking how it's solved there

@talheim-it
Copy link
Author

There are differences in the code by the share.button.css too.

The whole info is missing. I personally prefer the solution I build for our instance, I will check later when I have more time to fix it.

But that fix makes it usable for the moment for everyone on mobile who is using it.

@FuckingToasters
Copy link
Contributor

Check out #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mobile Version
3 participants