Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsLabelledNewick="true" or "false" ? #172

Open
walterxie opened this issue Nov 22, 2024 · 3 comments
Open

IsLabelledNewick="true" or "false" ? #172

walterxie opened this issue Nov 22, 2024 · 3 comments

Comments

@walterxie
Copy link
Collaborator

In TimeTreeToBEAST, should it uses IsLabelledNewick="true" or "false" as default:

BEAST 2 doc https://www.beast2.org/2014/07/28/all-about-starting-trees.html uses IsLabelledNewick="true", but this will cause the trouble when caring about the internal node index. Use "false", this problem will be solved.

@alexeid
Copy link
Collaborator

alexeid commented Nov 22, 2024

Surely false is wrong. Because in general we will not use only numbers for taxa names in lphy.

walterxie added a commit to alexeid/toroidalDiffusion that referenced this issue Nov 24, 2024
@walterxie
Copy link
Collaborator Author

CompEvol/beast2#1173

@walterxie
Copy link
Collaborator Author

Yes, I think we should leave this unchanged and see how the above beast development will improve the internal node id issue ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants