Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test ut_lind_fs_read_from_directory #63

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ChinmayShringi
Copy link
Contributor

@ChinmayShringi ChinmayShringi commented Oct 22, 2024

Description

Fixes # (issue)

Added a clean-up step to ensure the test environment is always reset before the mkdir operation in the ut_lind_fs_read_from_directory test case. The line let _ = cage.rmdir_syscall(old_path); was introduced to remove the directory if it already exists, ensuring a clean environment for testing. This change enhances the reliability of the test by preventing conflicts from pre-existing directories.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • cargo test ut_lind_fs_read_from_directory

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

@ChinmayShringi ChinmayShringi force-pushed the fix-ut-lind-fs-read-from-directory branch from be7a942 to 8c12668 Compare October 24, 2024 02:16
@ChinmayShringi ChinmayShringi changed the title fix: test ut_lind_fs_lseek_on_directory fix: test ut_lind_fs_read_from_directory Oct 24, 2024
@JustinCappos JustinCappos merged commit 815991c into main Oct 24, 2024
1 check failed
@Yaxuan-w Yaxuan-w deleted the fix-ut-lind-fs-read-from-directory branch October 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants