[조은서] 리액트 과제 끝! #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devHudi
requested changes
May 8, 2022
Comment on lines
+21
to
+26
| <MediaCard | ||
| backgroundImage="https://t4.ftcdn.net/jpg/01/09/88/85/240_F_109888581_d2vqgQnNiNkGRfZPFpIYlS5FIYNBD3ch.jpg" | ||
| title="Heading" | ||
| text="This is a short description about the card." | ||
| backgroundColor="linear-gradient(135deg, #667eea 0%, #764ba2 100%);" | ||
| ></MediaCard> |
There was a problem hiding this comment.
이 코드는 아래와 같이 self-closing 을 활용하여 변경할 수 있을 것 같아요. 한번 찾아볼까요?
Suggested change
| <MediaCard | |
| backgroundImage="https://t4.ftcdn.net/jpg/01/09/88/85/240_F_109888581_d2vqgQnNiNkGRfZPFpIYlS5FIYNBD3ch.jpg" | |
| title="Heading" | |
| text="This is a short description about the card." | |
| backgroundColor="linear-gradient(135deg, #667eea 0%, #764ba2 100%);" | |
| ></MediaCard> | |
| <MediaCard | |
| backgroundImage="https://t4.ftcdn.net/jpg/01/09/88/85/240_F_109888581_d2vqgQnNiNkGRfZPFpIYlS5FIYNBD3ch.jpg" | |
| title="Heading" | |
| text="This is a short description about the card." | |
| backgroundColor="linear-gradient(135deg, #667eea 0%, #764ba2 100%);" | |
| /> |
Comment on lines
+11
to
+24
| font-size: 45px; | ||
| color: ${(props) => (props.fColor ? props.fColor : "black")}; | ||
| `; | ||
|
|
||
| const ColorWrapper = styled.div` | ||
| height: 350px; | ||
| border: 1px solid black; | ||
| border-top: 0; | ||
| border-left: 0; | ||
| border-right: 0; | ||
| border-top-left-radius: 10px; | ||
| border-top-right-radius: 10px; | ||
| background-color: ${(props) => (props.bColor ? props.bColor : "black")}; | ||
| `; |
There was a problem hiding this comment.
지금은 혼자 개발하지만, 다른 개발자와 협업을 하게 될 경우 축약하여 네이밍 하는 경우 그 의미를 정확히 전달하기 어려워지는데요, fColor 를 fontColor 로, bColor 를 backgroundColor 로 명확히 작성하면 더 훌륭한 코드가 될 것 같아요 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1번
2번
3번
