Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: LogAUC #2377

Merged
merged 51 commits into from
Nov 12, 2024
Merged

New metric: LogAUC #2377

merged 51 commits into from
Nov 12, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 13, 2024

What does this PR do?

Fixes #2304

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2377.org.readthedocs.build/en/2377/

@SkafteNicki SkafteNicki added enhancement New feature or request New metric labels Feb 13, 2024
@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Feb 13, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Classif topic: Regress labels Feb 13, 2024
@Borda Borda changed the title Newmetric: LogAUC adding wew metric LogAUC Mar 4, 2024
@Borda Borda changed the title adding wew metric LogAUC adding new metric LogAUC Mar 4, 2024
@Borda
Copy link
Member

Borda commented May 21, 2024

@SkafteNicki, what is missing here to make it land? 🐿️

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 69.81132% with 48 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (8f6936d) to head (71e1684).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2377    +/-   ##
=======================================
  Coverage      69%     69%            
=======================================
  Files         344     346     +2     
  Lines       18969   19129   +160     
=======================================
+ Hits        13115   13227   +112     
- Misses       5854    5902    +48     

@Borda
Copy link
Member

Borda commented Nov 4, 2024

seems one of the needed packages is missing for py3.12
ref:kuelumbus/rdkit-pypi#111 (comment)
and mims-harvard/TDC#328

@mergify mergify bot added the ready label Nov 11, 2024
@Borda Borda merged commit d73e6c1 into master Nov 12, 2024
68 checks passed
@Borda Borda deleted the newmetric/logauc branch November 12, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request New metric ready topic: Classif
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogAUC metric
2 participants