Remove apt settings from project #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woodii1998
reviewed
Nov 28, 2024
|
|
||
| update-mime-database /usr/share/mime || true | ||
| update-desktop-database /usr/share/applications || true | ||
|
|
There was a problem hiding this comment.
The lines of code above should be retained as they ensure that the software can be correctly recognized and launched in the browser on Linux.
There was a problem hiding this comment.
In the Linux system, you can type lichtblick:// in the address bar of the browser to verify my statement. If you delete the above four lines of code, the browser will not be able to correctly trigger the application.
There was a problem hiding this comment.
Yes it makes sense. As I don't have Linux here to test at the moment, I will restore the files and remove only the APT part
aneuwald-ctw
force-pushed
the
feature/remove-apt-settings
branch
from
bb37a20
to
d2b8883
Compare
aneuwald-ctw
force-pushed
the
feature/remove-apt-settings
branch
from
d2b8883
to
af2e1d4
Compare
|
laisspportugal
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Users current have problems to run apt commands due to this configuration, that is not being used anymore in Lichtblick.
Description
Removed completely the functionality of update on ubuntu via APT, as we do not currently support this.
Checklist