[stable29] feat: allow to change signature hash algorithm #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-libresign[bot]](https://avatars.githubusercontent.com/in/125700?s=60&v=4){kind=small}
When we make a patch at a signature request, the signature method need to be always returned and this continue was removing the signature methods from return object. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
The default hash algorithm of JSignPdf is SHA1 and with this change was defined SHA256 as default hash algorithm and make possible choose between the allowed algorithms: SHA1, SHA256, SHA384, SHA512, RIPEMD160. To don't throw the follow message, was implemented a logic to identify the right algorithm to sign the document depending of PDF version but the implemented algorithm usign the prefix of PDF file, isn't effective. The best way to identify the pdf version is using the command pdfinfo of poppler-utils. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
backport/4183/stable29
branch
from
34f8596 to
c663c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4183
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.