fix: fetch signature methods #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we make a patch at a signature request, the signature method need to be always returned and this continue was removing the signature methods from return object. Signed-off-by: Vitor Mattos <[email protected]>
|
/backport to stable30 |
|
/backport to stable29 |
vitormattos
force-pushed
the
fix/fetch-signature-methods
branch
2 times, most recently
from
8eed393 to
835a691
Compare
Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
fix/fetch-signature-methods
branch
from
835a691 to
047b89a
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/4185/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d31748bc 047b89a4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4185/stable29Error: Failed to push branch backport/4185/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we make a patch at a signature request, the signature method need to be always returned and this continue was removing the signature methods from return object.
Side effects of previous code: When I make a patch of herself sign request, I can't sign the document if the file list wasn't updated because the signature methods is returned to each element when we are listing the files. With this change is possible to return the signature methods after I'm added to be a signer and go ahead to sign the document.