Skip to content

Commit

Permalink
Merge pull request #1733 from LibreSign/feature/remove-unecessary-ann…
Browse files Browse the repository at this point in the history
…otations

Remove unecessary annotations
  • Loading branch information
vitormattos authored May 26, 2023
2 parents c933f93 + 459ec3d commit a1d879e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
2 changes: 1 addition & 1 deletion lib/Controller/AdminController.php
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public function downloadBinaries(): Response {
}

#[NoAdminRequired]
public function downloadStatus(): dataResponse {
public function downloadStatus(): DataResponse {
$return = $this->installService->getTotalSize();
return new DataResponse($return);
}
Expand Down
19 changes: 4 additions & 15 deletions lib/Controller/RequestSignatureController.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,11 @@ public function __construct(
* Request signature
*
* Request that a file be signed by a group of people
*
* @param array $file
* @param array $users
* @param string $name
* @param string|null $callback
* @return JSONResponse
*/
#[NoAdminRequired]
#[NoCSRFRequired]
#[RequireManager]
public function request(array $file, array $users, string $name, ?string $callback = null, ?int $status = 1) {
public function request(array $file, array $users, string $name, ?string $callback = null, ?int $status = 1): JSONResponse {
$user = $this->userSession->getUser();
$data = [
'file' => $file,
Expand Down Expand Up @@ -96,15 +90,10 @@ public function request(array $file, array $users, string $name, ?string $callba
);
}

/**
* @param string $uuid
* @param array $users
* @return JSONResponse
*/
#[NoAdminRequired]
#[NoCSRFRequired]
#[RequireManager]
public function updateSign(?array $users = [], ?string $uuid = null, ?array $visibleElements = null, ?array $file = [], ?int $status = null) {
public function updateSign(?array $users = [], ?string $uuid = null, ?array $visibleElements = null, ?array $file = [], ?int $status = null): JSONResponse {
$user = $this->userSession->getUser();
$data = [
'uuid' => $uuid,
Expand Down Expand Up @@ -145,7 +134,7 @@ public function updateSign(?array $users = [], ?string $uuid = null, ?array $vis
#[NoAdminRequired]
#[NoCSRFRequired]
#[RequireManager]
public function deleteOneRequestSignatureUsingFileId(int $fileId, int $fileUserId) {
public function deleteOneRequestSignatureUsingFileId(int $fileId, int $fileUserId): JSONResponse {
try {
$data = [
'userManager' => $this->userSession->getUser(),
Expand Down Expand Up @@ -176,7 +165,7 @@ public function deleteOneRequestSignatureUsingFileId(int $fileId, int $fileUserI
#[NoAdminRequired]
#[NoCSRFRequired]
#[RequireManager]
public function deleteAllRequestSignatureUsingFileId(int $fileId) {
public function deleteAllRequestSignatureUsingFileId(int $fileId): JSONResponse {
try {
$data = [
'userManager' => $this->userSession->getUser(),
Expand Down

0 comments on commit a1d879e

Please sign in to comment.