Add keyboard lock to full screen mode #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's lots of noise because of trailing whitespace. The actual change begins here. |
|
Is there any interest in merging this? For background: https://developer.chrome.com/blog/better-full-screen-mode/#in-practice. |
|
@andreasrosdal, great to see this in fciv.net. @Lexxie9952, are you interested in this improvement, too? |
|
I recommend contributing to FCIV.NET on https://github.com/freecivx/freecivx for an open source project with the goal of creating Freeciv 3D. I am sure it can be an interesting project for testing out new Google Chrome technologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This progressive enhancement changes full screen mode to require a long press of the Esc key, so that the player doesn't accidentally leave it when they want to cancel an in-game dialog.
Before:
After: