Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Make github actions to run on ubuntu-20.04 #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cazfi
Copy link
Contributor

@cazfi cazfi commented Nov 6, 2021

Make FCW Continuous Integration build tests on github to run on ubuntu-20.04 instead of ubuntu-18.04.

It's for FCW project to decide when they want to make that switch, i.e., to merge this patch. There are arguments for waiting, and there are arguments for merging it already.

  • As FCW vagrant builds, and I presume production, runs on ubuntu-18.04, there's obvious benefit in keeping CI testing the environment they deliver (not merging this patch yet)
  • OTOH ubuntu-18.04 environment gets also tested in their ubuntu-18.04 based development (vagrant builds), so switching CI to test on ubuntu-20.04 (merging this patch already) would increase coverage of their testing to the environment they have to be migrating at some point anyway. They don't want to accidentally break build on their future environment, ubuntu-20.04.

I have had no github setup to test the patch before making this Pull Request. When github actions get triggered by creation of this Pull Request, it will be the first test of this patch. Pay attention to results.

@cazfi
Copy link
Contributor Author

cazfi commented Nov 6, 2021

I have had no github setup to test the patch before making this Pull Request. When github actions get triggered by creation of this Pull Request, it will be the first test of this patch. Pay attention to results.

Well, it was a quick failure! Apparently update to tomcat9 is needed first. I have a patch for that waiting, but have not submitted it yet because I've been concerned that it might break things in FCW.

@cazfi cazfi mentioned this pull request Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant