Update "device app" part #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@tdejoigny-ledger you can remove import { Cards, Card } from 'nextra/components' here.
There was a problem hiding this comment.
@tdejoigny-ledger can you:
- add the import for the Callout component
- put the graphic back in
/docs/device-app/develop. It will be improved very soon so it makes more sense on the develop page.
There was a problem hiding this comment.
ok for the missing import.
For the graphics, for me it could be more relevant to let it in quickstart section where we begin to talk about ledger extension. In develop section, there is no context to introduce this graphic.
tdejoigny-ledger
force-pushed
the
tdj/device_app_update
branch
from
f0d3faf
to
c7c3ad4
Compare
tdejoigny-ledger
force-pushed
the
tdj/device_app_update
branch
from
0b6a75c
to
ddfc4a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typos, dead links, update content